Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Added new method for creating ibis circuit schematic starting from a list of pins in the schematic #4937

Merged
merged 21 commits into from
Jul 22, 2024

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 85.07463% with 20 lines in your changes missing coverage. Please review.

Project coverage is 83.42%. Comparing base (eb9f171) to head (2efe06d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4937      +/-   ##
==========================================
+ Coverage   82.18%   83.42%   +1.23%     
==========================================
  Files         120      120              
  Lines       54403    54458      +55     
==========================================
+ Hits        44712    45432     +720     
+ Misses       9691     9026     -665     

pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
@gmalinve
Copy link
Contributor

gmalinve commented Jul 19, 2024

@maxcapodi78 general comment: let's try to be consistent with naming convention with words such as IBIS or AMI. Should they always be upper or lower case? at the moment there's a mix.
Also, when you mention 'unit' shouldn't it be 'units'? specifically in 'unit_intervals'.

pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the examples Anything related to the examples label Jul 19, 2024
@maxcapodi78 maxcapodi78 added the enhancement New features or code improvements label Jul 19, 2024
@maxcapodi78 maxcapodi78 merged commit af937c3 into main Jul 22, 2024
46 checks passed
@maxcapodi78 maxcapodi78 deleted the add_ibis_circuit_creation branch July 22, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements examples Anything related to the examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants